Additions necessary for integration of pantry into stackage-server: #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
changes-for-stackage-server
branch
2 times, most recently
from
d411fb3 to
ca37930
Compare
snoyberg
reviewed
Apr 14, 2019
* Addition of few class instances and exports needed for stackage-server * Fixed concurrent blob and file name writes in multi-connection sql pool setting. Added few more exports needed for stackage-server * Improved speed and safety by added database aware queries. Switched all queries to MonadIO * Removed pantry cabal file and added it to gitignore * Export PackageName and Version and aded NFData instances for PackageNameP and VersionP * Lower restriction from RIO to MonadUnliftIO for sql query running in `withStorage` * Turned on `-Wall` for pantry tests.
…or Stackage Server
…e an extra data type to handle it
lehins
force-pushed
the
changes-for-stackage-server
branch
from
b18e364 to
4767c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonadIO2, since that is what majority of code has.Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!