Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dot and ls dependencies not require GHC #4632

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Make dot and ls dependencies not require GHC #4632

merged 4 commits into from
Mar 18, 2019

Conversation

snoyberg
Copy link
Contributor

The previous approach in #4405 would no longer work, due to @qrilka's explanation in #4405 (comment). This implementation adds a new flag --global-hints which allows the user to bypass the need for an installation of GHC. We could arguably flip the default to not requiring GHC to be installed.

This will close #4390.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

snoyberg added 2 commits March 17, 2019 12:50
@snoyberg
Refactor to make it clearer where dot needs EnvConfig
e86cd86 
This is towards addressing:

* #4390
* #4405
@snoyberg
Add --global-hints flag for dot and ls dependencies
e34bfe2 
This flag allows us to bypass the need for an installation of GHC for
these commands, at the cost of not getting completely accurate
information on packages that ship with GHC.

* Fixes #4390
* Closes #4405
@snoyberg snoyberg requested a review from qrilka March 18, 2019 10:47
@snoyberg snoyberg mentioned this pull request Mar 18, 2019
Closed
2 tasks
qrilka
qrilka approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@qrilka qrilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small not about commented out code looks good to me

src/Stack/Package.hs Outdated Show resolved Hide resolved
@snoyberg snoyberg merged commit 7b1ad17 into master Mar 18, 2019
@snoyberg snoyberg deleted the 4390-dot-doesnt-need-ghc branch March 18, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qrilka qrilka qrilka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple commands should work without ghc installed
2 participants
@snoyberg @qrilka