-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curator stackage build with stack #4582
Conversation
This reverts commit 59acc7d.
Prevent all-in-one build only for not yet installed library when test failures are expected
The last rebuild took
so it looks more or less OK and #4550 should improve it a bit more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked this over and discussed with @qrilka. This all looks good to me. Only concern is whether mutable packages trigger rebuilds appropriately. Recommendation: add an integration test that works as following:
- Mutable, local copy of a package like
filepath
inextra-deps
- Single local package that depends on a package in the snapshot which uses
filepath
- Perform a non-profiling build
- Perform a profiling build
This will necessitate rebuilding all three packages (filepath
, the one depending on it, and the local package). If this works, then we're good.
@snoyberg looks like I found a problem which is a bit related to removing of
I will work on fixing this (and will add a test for that of course) |
Also includes a test for this functionality
Fixed rebuilds and added 2 integration tests |
Please include the following checklist in your PR:
Tested using the latest Stackage snapshot builds.
Fixes #4217
This mostly changes
curator
code but also adds extra tweaks into Stack's code to deal properly with expected test and benchmark failures