Fix (in part) #4204: Honour NO_COLOR variable
#4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopt the standard proposed at `http://no-color.org/`, that color should not be added by default if the `NO_COLOR` environment variable is present, by adapting `defaultColorWhen` in module `Stack.DefaultColorWhen`.
mihaimaruseac
approved these changes
Aug 25, 2018
|
@mihaimaruseac, it seems that merging this was a little premature - there is a problem with the Unix build. I'm about to make a further pull request that fixes that. |
mpilgrem
added a commit
to mpilgrem/stack
that referenced
this pull request
Aug 25, 2018
Merged commercialhaskell#4260 was missing some imports in the unix version.
2 tasks
|
Thanks. That should teach me not to rush things. |
mihaimaruseac
added a commit
that referenced
this pull request
Aug 26, 2018
Repair PR #4260: Add imports to Stack.DefaultColorWhen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the standard proposed at http://no-color.org/, that colour should not be added by default if the
NO_COLORenvironment variable is present, by adaptingdefaultColorWhenin moduleStack.DefaultColorWhen(which varies depending on whether the operating system is Windows or Unix-like).Please also shortly describe how you tested your change. Bonus points for added tests!
Tested on Windows 10 by building -
stack test- and using the built tool, as below: