Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4183 Make PrettyPrint styles background-agnostic #4184

Merged
merged 1 commit into from
Jul 28, 2018
Merged

Fix #4183 Make PrettyPrint styles background-agnostic #4184

merged 1 commit into from
Jul 28, 2018

Conversation

mpilgrem
Copy link
Member

This implements the suggestion in #4183. Tested on macOS, giving this 'after' result (see #4183 for the equivalent 'before' result):

image

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md Not-ChangeLog.md-worthy
  • The documentation has been updated, if necessary. N/A

@mpilgrem mpilgrem mentioned this pull request Jul 28, 2018
Closed
mihaimaruseac
mihaimaruseac approved these changes Jul 28, 2018
View reviewed changes
Copy link
Contributor

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to check how it looks for me on various terminal schemes but I need to merge it before (don't want to reclone an entire new repo and rebuild everything from scratch)

@mihaimaruseac mihaimaruseac merged commit 413cf2b into commercialhaskell:master Jul 28, 2018
@mihaimaruseac
Copy link
Contributor

mihaimaruseac commented Jul 28, 2018 •
edited
Loading

I'm going to revert this, as on a white terminal the text is not readable:

screenshot from 2018-07-28 08-27-50
screenshot from 2018-07-28 08-29-50

@mpilgrem mpilgrem mentioned this pull request Jul 28, 2018
Closed
@mpilgrem
Copy link
Member Author

@mihaimaruseac, I have commented on the 'not readable' problem in the issue #4183.

@mpilgrem mpilgrem deleted the fixStyles branch July 28, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpilgrem @mihaimaruseac