'stack ghci' now asks which main module to load before building #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, 'stack ghci' would ask the user a question after doing a build which may take a long time. The reason it was this way is that the question required resolution of package files, and package file resolution needed to come after the build due to #1180. The solution here is to resolve the package files twice - once before the build - and once after. This isn't the most efficient solution possible, but it is a much better user experience to ask the main target question before building rather than after.
| , getInstalledSymbols = False | ||
| } | ||
| sourceMap | ||
| let localLibs = |
There was a problem hiding this comment.
I think we should add the internal libs here too, if they exist
There was a problem hiding this comment.
Agreed! Perhaps that can be done in a separate PR? This bit is just a refactoring, same logic as before the change.
There was a problem hiding this comment.
Sure. I'm travelling now but can look at it in two weeks and see to it.
mihaimaruseac
approved these changes
Jul 9, 2018
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, 'stack ghci' would ask the user a question after doing a
build which may take a long time. The reason it was this way is that the
question required resolution of package files, and package file resolution
needed to come after the build due to #1180.
The solution here is to resolve the package files twice - once before the build,
and once after. This isn't the most efficient solution possible, but it is a
much better user experience to ask the main target question before building
rather than after.
Tested this by running on a large project and observing that ghci functions properly, and that the main target question is asked before the build.