Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention tarball earlier in sdist #4117

Merged
merged 3 commits into from
Jul 1, 2018
Merged

Mention tarball earlier in sdist #4117

merged 3 commits into from
Jul 1, 2018

Conversation

isovector
Copy link
Contributor

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

This change seems too small to need being mentioned in the ChangeLog.

Testing it by hitting CI and making sure nothing breaks.

@isovector isovector mentioned this pull request Jun 25, 2018
Closed
snoyberg
snoyberg previously requested changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a note to the ChangeLog about the change with a link to the issue it's solving?

@isovector isovector dismissed snoyberg’s stale review July 1, 2018 07:26

please take another look

@snoyberg snoyberg merged commit 8188999 into commercialhaskell:master Jul 1, 2018
@snoyberg
Copy link
Contributor

snoyberg commented Jul 1, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isovector @snoyberg