Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ease single directory requirement #3794

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Conversation

dwaldhalm
Copy link
Contributor

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@kadoban
Copy link
Collaborator

kadoban commented Jan 18, 2018

Hm, is this the right way to fix this problem? (Not asking rhetorically, I really don't know.)

If the issue is that stack is leaving the tarball in place and that's why the test is failing, shouldn't we instead fix that problem so the test of if the tarball is in the right form can be run correctly? Or is that hard to do for some reason?

Or maybe there's no harm in making the check less strict, though I can think of a lot of forms of tarballs that will accidentally pass this that wouldn't really be what is expected.

@dwaldhalm
Copy link
Contributor Author

That's a fair question, but I can't answer it--I'm not familiar with stack (just a user / fan). In this case, it seems to effect only a temp directory that is ultimately deleted. No .tar file remains in my bin.

@mgsloan
Copy link
Contributor

mgsloan commented Jan 19, 2018

Yeah, on one hand it seems good to check "are things as we expect them to be". On the other hand, someone might want to include a README at the top level of their tarball or something. So I'm fine with weakening the check. Since this is happening in a temp directory, it will get deleted regardless.

Thanks for the PR!

@mgsloan mgsloan merged commit 02edec9 into commercialhaskell:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants