Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Clean up --only-dependencies logic in ConstructPlan" #3495

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

rjmk
Copy link
Contributor

@rjmk rjmk commented Oct 17, 2017

This reverts commit d1e6c48 and resolves #3476

The problem is caused specifically in the PSFiles -> Nothing branch of installPackages.

As the flag was no longer being passed through, packages were not being checked for being in the wanted map. This led to the local packages being built as dependencies

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

I tested this by running stack --only-dependencies --dry-run on our stack project with multiple packages. Setting the call to resolveDepsAndInstall's treatAsDep value to True causes the problem and removing it removes the problem

@mgsloan
Copy link
Contributor

mgsloan commented Oct 17, 2017

Hmm, I guess I did not consider the logic fully when implementing that change. My bad! The logic there is still rather confusing, but if this fixes the current case, then seems reasonable.

Thanks for tracking it down!

@mgsloan mgsloan merged commit 154e547 into commercialhaskell:master Oct 17, 2017
@rjmk rjmk deleted the revert-construct-plan-logic branch October 18, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack builds packages when called with --only-dependencies in some multi-package projects
2 participants