Support building the sdist and upload tarball #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-kolinek
changed the title
|
Holy moly! I've been wanting this feature since a year now 😄 Don't have time to look at this now but hopefully someone will stop by soon. Nice one for this work! (CI Failure was just an OOM it seems!) |
martin-kolinek
force-pushed
the
sdist-build
branch
from
44ce136 to
54dc3bd
Compare
martin-kolinek
force-pushed
the
sdist-build
branch
from
54dc3bd to
e578211
Compare
|
Awesome, thanks! Implementation looks good, refactors appreciated too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option
--test-tarballtostack sdistandstack upload. When this option is specified, the tarball is extracted, and tests are executed as part of the process. This should implement part of #717.The implementation works by building the extracted tarball using the default build options. The package directory in the
BuildConfigused for building and testing is replaced by the location of the extracted tarball.There is currently no way to specify build options.
The added tests work with packages which fail to build/test because the build depends on a file which is not packaged into the resulting tarball.