-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of "--copy-compiler-tool" #2643 #2812
Conversation
0645678
to
bb243e4
Compare
|
All done messing with integration tests. I can't find anything wrong currently, as far as I know it's good to go.
Edit: I got annoyed by the hard-to-review merge and rebased. Should be easier to see now. Original is at kadoban/stack@89ea8cb if you want it. Edit2: re-rebased, only conflict was closes #2643 |
89ea8cb
to
0e5a232
Compare
0e5a232
to
be9f4a1
Compare
Hmm. I can't tell what's up with those travis-ci jobs. One is complaining about |
The missing build tools should have been fixed by #3249? I see you've rebased so this could be a regression 💣? Best to just re-run those > 50 min builds. Nice one on this so far 👍 EDIT: Actually, the latest build on master failed with the missing |
@lwm Ah nice, thanks for looking into it. |
LGTM, thanks! |
Is this feature included in 1.5.1? |
@osa1, it's in unreleased changes, so no. You can get it with |
As described in #2643, this implements a mechanism for having a bin directory for tools that match a particular ghc version. This compiler specific dir looks like is
/home/mgsloan/.stack/compiler-tools/x86_64-linux/ghc-8.0.1/bin
. It is included on the PATH when stack is building projects and when running exec. It adds:stack path --compiler-tool-bin
, yielding a path to the dir compiler-specific tools are installed tostack build --copy-compiler-tool
, which causes executables for target packages to get copied to the compiler-specific dir.Tested this change by using it to install a local intero. Querying
stack exec -- which intero
yielded the correct path. `stack path --local