Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of "--copy-compiler-tool" #2643 #2812

Merged
merged 5 commits into from
Aug 20, 2017
Merged

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Nov 28, 2016

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

As described in #2643, this implements a mechanism for having a bin directory for tools that match a particular ghc version. This compiler specific dir looks like is /home/mgsloan/.stack/compiler-tools/x86_64-linux/ghc-8.0.1/bin. It is included on the PATH when stack is building projects and when running exec. It adds:

  1. stack path --compiler-tool-bin, yielding a path to the dir compiler-specific tools are installed to
  2. stack build --copy-compiler-tool, which causes executables for target packages to get copied to the compiler-specific dir.

Tested this change by using it to install a local intero. Querying stack exec -- which intero yielded the correct path. `stack path --local

@kadoban
Copy link
Collaborator

kadoban commented Aug 12, 2017

WIP: Edit: done

  • Merge in master to fix conflicts
  • Fix compilation issues
  • Review auto-merged files for sanity
  • Test behavior for correctness
  • Write an integration test or two?
  • Make the integration test suck less

@kadoban
Copy link
Collaborator

kadoban commented Aug 14, 2017

All done messing with integration tests. I can't find anything wrong currently, as far as I know it's good to go.

By the way, github's display of the merge of master into this is really confusing. I reviewed using git diff 5363a8ef^2 5363a8ef and checked against git show bb243e4 (@mgsloan's original commit in this PR) if that helps anyone review. Let me know if you'd like me to rebase this and clean up this history a bit, it wouldn't take really any time.

Edit: I got annoyed by the hard-to-review merge and rebased. Should be easier to see now. Original is at kadoban/stack@89ea8cb if you want it.

Edit2: re-rebased, only conflict was Changelog.md

closes #2643

@kadoban kadoban force-pushed the 2643-copy-compiler-tool branch from 89ea8cb to 0e5a232 Compare August 17, 2017 05:30
@kadoban kadoban force-pushed the 2643-copy-compiler-tool branch from 0e5a232 to be9f4a1 Compare August 20, 2017 03:28
@kadoban
Copy link
Collaborator

kadoban commented Aug 20, 2017

Hmm. I can't tell what's up with those travis-ci jobs. One is complaining about happy missing, the other timed out? I can't tell how I would have caused that. Maybe it's a transient thing?

@decentral1se
Copy link
Member

decentral1se commented Aug 20, 2017

The missing build tools should have been fixed by #3249? I see you've rebased so this could be a regression 💣? Best to just re-run those > 50 min builds. Nice one on this so far 👍

EDIT: Actually, the latest build on master failed with the missing happy error as well.

@kadoban
Copy link
Collaborator

kadoban commented Aug 20, 2017

@lwm Ah nice, thanks for looking into it.

@mgsloan
Copy link
Contributor Author

mgsloan commented Aug 20, 2017

LGTM, thanks!

@mgsloan mgsloan merged commit e6fde2e into master Aug 20, 2017
@osa1
Copy link

osa1 commented Sep 29, 2017

Is this feature included in 1.5.1?

@decentral1se
Copy link
Member

decentral1se commented Sep 29, 2017

@osa1, it's in unreleased changes, so no. You can get it with stack upgrade --git though.

@mgsloan mgsloan deleted the 2643-copy-compiler-tool branch January 2, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants