Try to limit line lengths in exception messages to 100 chars #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
changed the title
sjakobi
force-pushed
the
format-exceptions
branch
from
adab2ef to
4e4173c
Compare
sjakobi
changed the title
|
On second thought, I think this would break any kind of indentation. Leaving it open for now in case someone wants to discuss. |
|
I think it makes sense to discuss this in the context of #2650 . Closing for now, but it's a good idea! I would prefer that we switch over to pretty printing for everything, including exceptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an experiment to improve the formatting of exception messages which can sometimes get quite long.
Further refinements or other suggestions are welcome.