-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve 'stack new' #1532
improve 'stack new' #1532
Conversation
- don't say we're "Downloading" a local file - logDebug what file we're opening
79d36a6
to
2ad15e6
Compare
exists <- fileExists path | ||
unless exists ($logDebug "Template file doesn't exist") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these $logDebug
s intended to be visible to the user? They'll only be present in the -v
output.
It probably makes sense to delete this one since it's a bit redundant with the exception. But perhaps it helps resolve ambiguity when debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, that is quite redundant now. I'll nuke it. (I think it exists from when I was doing my own debug briefly and just forgot to remove it)
LGTM!
Yeah, this would be nice, particularly if a file URL would just use a folder for the templates. I think it might make sense to change how templates are done, in order to support this + to work offline: #1251 (comment) Of course, that's bonus points, merging this isn't predicated on doing that. |
Yay :)
Yeah I agree, that sounds like quite a nice way to go. I'll ponder a bit and respond in that thread if anything interesting comes to mind. I'd be interested in working on improving
Cool. Yeah I'd say most/all of this should end up useful even once something in that direction gets implemented, if only because requiring git probably isn't ideal (so it has to work without it at least in some fashion). |
I considered adding the ability to configure the template repository location, but I'm thinking I might leave that for a separate PR later if it sounds interesting to anyone. I think it'd be a decent feature, but it's a little complicated by the existence of the
stack templates
command, which I haven't really worked out how to deal with.I'm working on some tests to exercise this functionality and make sure, but it basically seems to work fine to me.