Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for detailed-0.9 test type #1447

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

luigy
Copy link
Contributor

@luigy luigy commented Nov 28, 2015

[WIP] resolves #1429

TODO:

stack test --coverage

@mgsloan
Copy link
Contributor

mgsloan commented Nov 30, 2015

Thanks for working on this! I've added a couple comments.

 clean up test output

Seems fine to me, the only issue is #1302

 choose a proper log filepath to pass to the testStub?

Is this necessary? The existing code already writes to logfiles when not outputting to the console (e.g. when running tests in parallel).

If a logfile is necessary, though, something which uses some suffix like "test-detailed" alongw tih buildLogPath should do.

 handle unsupported TestType (throw an error?)

Throwing an error seems reasonable.

@luigy luigy force-pushed the detailed-test-support-1429 branch 2 times, most recently from 00fb0c3 to 8fc49b9 Compare December 2, 2015 03:00
@luigy luigy force-pushed the detailed-test-support-1429 branch from 8fc49b9 to 50dd563 Compare December 3, 2015 04:17
mgsloan added a commit that referenced this pull request Dec 3, 2015
@mgsloan mgsloan merged commit 4b968b8 into commercialhaskell:master Dec 3, 2015
@mgsloan
Copy link
Contributor

mgsloan commented Dec 3, 2015

Thanks!

1 similar comment
@michaxm
Copy link

michaxm commented Dec 3, 2015

Thanks!

@luigy luigy deleted the detailed-test-support-1429 branch December 3, 2015 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stack test with detailed-0.9 fails (executable not found)
3 participants