Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some housekeeping in Stack.Types.Config #1326

Merged
merged 3 commits into from
Nov 12, 2015

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Nov 10, 2015

No description provided.

@sjakobi
Copy link
Member Author

sjakobi commented Nov 10, 2015

Should the "command-specific" types for eval, exec and setup possibly be moved to their own Stack.Types.X modules?

@drwebb
Copy link
Contributor

drwebb commented Nov 10, 2015

We are hoping to bring together config commands into one place so we can improve the entire config system, so distributing the types out to their different modules probably isn't the best idea. If anything we might want to refactor the command specific types to a submodule of Stack.Types.Config, like Stack.Types.Config.Setup for example.

@sjakobi
Copy link
Member Author

sjakobi commented Nov 10, 2015

We are hoping to bring together config commands into one place so we can improve the entire config system

Ok, that sounds very reasonable! Looking forward to the results!

drwebb pushed a commit that referenced this pull request Nov 12, 2015
Some housekeeping in Stack.Types.Config
@drwebb drwebb merged commit 2f00f7b into commercialhaskell:master Nov 12, 2015
@sjakobi sjakobi deleted the types-config-docs branch February 6, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants