Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack config add resolver command #1202

Merged
merged 2 commits into from
Oct 20, 2015
Merged

Stack config add resolver command #1202

merged 2 commits into from
Oct 20, 2015

Conversation

drwebb
Copy link
Contributor

@drwebb drwebb commented Oct 20, 2015

config selects the projects stack.yaml, regardless of directory

Parsing of config add command

Integration test helper (will be used to compare stack.yaml files)

Check to see if snapshot exists before writing

TODO:
Adding differnet fields
Additional subcommands for git

config selects the projects stack.yaml, regardless of directory

Parsing of config add command

Integration test helper (will be used to compare stack.yaml files)

Check to see if snapshot exists before writing

TODO:
Adding differnt fields
Additional subcommands for git
"resolver"
(Yaml.String newResolverText)
projectYamlConfig
liftIO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More efficient: just use Yaml.encodeFile. Definitely not necessary to convert from a strict ByteString to a lazy ByteString via a Builder.

@snoyberg
Copy link
Contributor

I had one comment about Yaml.encode, plus the GHC 7.8.4 build failure. Once those are addressed, this is good to merge!

drwebb pushed a commit that referenced this pull request Oct 20, 2015
@drwebb drwebb merged commit 1de8e14 into master Oct 20, 2015
@drwebb drwebb deleted the 115-set-resolver branch October 20, 2015 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants