Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stack sig sign sdist and stack upload --sign #1086

Merged
merged 2 commits into from
Nov 27, 2015

Conversation

dysinger
Copy link
Contributor

@dysinger dysinger commented Oct 1, 2015

No description provided.


-- | Extract the @PackageIdentifier@ given an exploded haskell package
-- path.
cabalFilePackageId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be replaced by some functions in Stack.Package, which will (1) avoid code duplication, and (2) ensure that Cabal library workarounds (like BOM stripping) are centralized to one place.

@borsboom
Copy link
Contributor

@dysinger / @snoyberg: I see there have been some more commits since the last comments. Is this ready to merge?

@snoyberg
Copy link
Contributor

I still see that some of my comments seem to be unaddressed.

@dysinger dysinger force-pushed the sig-sign-sdist-and-upload-sign branch 3 times, most recently from 6d3a86d to a46196f Compare November 26, 2015 02:08
@dysinger
Copy link
Contributor Author

I think the only one I haven't address is switching to System.Process.Read. This would be hard for one of the functions (verify) which needs to stream in on stdin and consume stderr after (& see a successful exit code). @borsboom talked about maybe adding to System.Process.Read in the future. I think this branch is ready to merge (after CI).

@borsboom
Copy link
Contributor

Can you add an entry to the change log, and also add/update any relevant documentation in doc/? If you'd rather I just merge this now and you'll come back to do those later, that's ok too, just let me know.

@dysinger dysinger force-pushed the sig-sign-sdist-and-upload-sign branch from a46196f to e156f8a Compare November 27, 2015 16:52
@dysinger
Copy link
Contributor Author

added a few lines to the ChangeLog.md & also to the GUIDE.md

borsboom added a commit that referenced this pull request Nov 27, 2015
…load-sign

Adds `stack sig sign sdist` and `stack upload --sign`
@borsboom borsboom merged commit d0d6143 into master Nov 27, 2015
@borsboom borsboom deleted the sig-sign-sdist-and-upload-sign branch November 27, 2015 16:56
@borsboom
Copy link
Contributor

Cool. Might be worth moving this to the "major changes" section of the changelog; I think it's worth calling extra attention to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants