-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds stack sig sign sdist
and stack upload --sign
#1086
Conversation
|
||
-- | Extract the @PackageIdentifier@ given an exploded haskell package | ||
-- path. | ||
cabalFilePackageId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be replaced by some functions in Stack.Package, which will (1) avoid code duplication, and (2) ensure that Cabal library workarounds (like BOM stripping) are centralized to one place.
I still see that some of my comments seem to be unaddressed. |
6d3a86d
to
a46196f
Compare
I think the only one I haven't address is switching to System.Process.Read. This would be hard for one of the functions (verify) which needs to stream in on stdin and consume stderr after (& see a successful exit code). @borsboom talked about maybe adding to System.Process.Read in the future. I think this branch is ready to merge (after CI). |
Can you add an entry to the change log, and also add/update any relevant documentation in |
a46196f
to
e156f8a
Compare
added a few lines to the ChangeLog.md & also to the GUIDE.md |
…load-sign Adds `stack sig sign sdist` and `stack upload --sign`
Cool. Might be worth moving this to the "major changes" section of the changelog; I think it's worth calling extra attention to it. |
No description provided.