-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using allow-newer-deps without allow-newer is a confusing experience #6086
Comments
@pbrisbin , thanks for reporting. The documentation certainly implies that |
So, if I build
So, I confirm that the two WARNINGs are not consistent with the documentation. |
Looks like you've already got it, but it's just the same exact error (which is not surprising the behavior's no different) but without the warning preamble.
|
@pbrisbin, I've identifed the problem and I have a pull request that is intended to fix it. |
Fix #6086 Correct warning when allow-newer-deps but allow-newer is false
Fix #6086 Improve allow-newer-dep messages
General summary/comments (optional)
I was compiling a package that needed to relax some upper bounds. I had set
allow-newer-deps
but didn't setallow-newer
. I know this is required as per documentation, and it failed in an expected way, but the messaging is confusing:You'll notice:
This is not true, it's not going to do this. If it did, it would not fail.
That's true, and is the information I needed, but it's not the "reason" for the "warning", right?
I think this case should instead look something like this:
Steps to reproduce
I can put together a reproduction if necessary, but I think my description above should be sufficient.
allow-newer
to compileallower-newer-deps
, but notallow-newer
Expected
A warning saying dependency bounds are NOT being ignored because
allow-newer-deps
is present butallow-newer
is not specified.Actual
A warning saying dependency bounds ARE being ignored because
allow-newer-deps
is present butallow-newer
is not specified.Stack version
Method of installation
Platform
Your platform (machine architecture and operating system)
The text was updated successfully, but these errors were encountered: