Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--ghc-options doesn't work with GHCJS #2714

Closed
mgsloan opened this issue Oct 18, 2016 · 2 comments
Closed

--ghc-options doesn't work with GHCJS #2714

mgsloan opened this issue Oct 18, 2016 · 2 comments
Labels
component: ghcjs type: bug
Milestone
P0: Blocking release

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Oct 18, 2016

Creating this to document a bug I discovered and have now fixed.

The issue is that we were passing in --ghc-options to Cabal, even when using ghcjs. Cabal will accept --ghc-options even when doing a build with ghcjs. Turns out we need to pass --ghcjs-options instead for them to actually get passed along to the compiler.
@mgsloan mgsloan added this to the P0: Blocking release milestone Oct 18, 2016
@mgsloan mgsloan mentioned this issue Oct 18, 2016
Closed
mgsloan added a commit that referenced this issue Oct 18, 2016
@mgsloan
Fix use of --ghc-options with GHCJS #2714
d94b1f0
@mgsloan mgsloan mentioned this issue Oct 18, 2016
Closed
@spl
Copy link

spl commented Oct 18, 2016

Great! So this can be closed?

@snoyberg snoyberg mentioned this issue Oct 18, 2016
Closed
@mgsloan
Copy link
Contributor Author

mgsloan commented Oct 18, 2016

Yep!

@mgsloan mgsloan closed this as completed Oct 18, 2016
@mgsloan mgsloan mentioned this issue Nov 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcjs type: bug
Projects
None yet
Milestone
P0: Blocking release
Development

No branches or pull requests
2 participants
@mgsloan @spl