Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-dependencies also includes test dependencies #1919

Closed
rikvdkleij opened this issue Mar 17, 2016 · 6 comments
Closed

list-dependencies also includes test dependencies #1919

rikvdkleij opened this issue Mar 17, 2016 · 6 comments

Comments

@rikvdkleij
Copy link

Would be nice if list-dependencies also shows test dependencies. For example with test flag.

@mgsloan
Copy link
Contributor

mgsloan commented Mar 17, 2016

Good point! Really, it should take a subset of build options (things that affect targets and flags)

@mgsloan mgsloan added this to the P2: Should milestone Mar 17, 2016
@rikvdkleij
Copy link
Author

@mgsloan
I would be very pleased if you could take a look to this issue.

@mgsloan
Copy link
Contributor

mgsloan commented Oct 10, 2016

@rikvdkleij Thanks for the ping!

It turned out to not be too much trouble to add support for TARGET syntax, --test, --bench, and --flag to both stack dot and stack list-dependencies

So this is now implemented! Please let me know if it doesn't work for your usecase.

@mgsloan mgsloan closed this as completed Oct 10, 2016
mgsloan added a commit that referenced this issue Oct 10, 2016
@rikvdkleij
Copy link
Author

@mgsloan
Thanks!! Solution looks fine to me. I will try to build Stack from master so I can test it.

@rikvdkleij
Copy link
Author

Yes, it works!! 👍

@rikvdkleij
Copy link
Author

Btw, #2603 is also fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants