Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build only some of the Docker images #1837

Closed
snoyberg opened this issue Feb 24, 2016 · 5 comments
Closed

Build only some of the Docker images #1837

snoyberg opened this issue Feb 24, 2016 · 5 comments

Comments

@snoyberg
Copy link
Contributor

Currently, stack image container always builds all images specified in your stack.yaml file. It would be convenient in some use cases to give a list of Docker images that should be built instead.

@dysinger dysinger added the ready label Mar 26, 2016
@dysinger dysinger self-assigned this Mar 26, 2016
dysinger added a commit that referenced this issue Mar 26, 2016
to `stack image container` (default to all images)

resolves #1837
@mgsloan mgsloan reopened this Mar 28, 2016
@mgsloan
Copy link
Contributor

mgsloan commented Mar 28, 2016

@dysinger I merged the PR before realizing that it takes these image names via an undecorated argument. I don't think this is what we want, because in the future we might also want to take TARGET syntax like the normal build command.

How about putting this option under a flag like stack image container --name or stack image container --image or something?

Bumping to P1 to ensure we address this before any release.

@mgsloan mgsloan added this to the P1: Must milestone Mar 28, 2016
@dysinger
Copy link
Contributor

How would multiple images look? stack image container --image black --image orange --image red ?

@dysinger dysinger added the ready label Mar 28, 2016
@mgsloan
Copy link
Contributor

mgsloan commented Mar 28, 2016

Yup, or possibly also stack image container --image "black orange red"

@dysinger
Copy link
Contributor

It seems reordering tickets on waffle.io adds back the "in progress" label

@borsboom
Copy link
Contributor

It looks like this issue can be closed. Please reopen if I'm incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants