Skip to content

Commit

Permalink
Comment out unused missing modules constr #2649
Browse files Browse the repository at this point in the history
  • Loading branch information
mgsloan committed Sep 28, 2016
1 parent 5575459 commit ebfec42
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/Stack/Package.hs
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,9 @@ resolveFilesAndDeps component dirs names0 exts = do
(S.toList unlistedModules)]
warnMissing _missingModules = do
return []
{- FIXME: the issue with this is it's noisy for modules like Paths_*
-- TODO: bring this back - see
-- https://github.com/commercialhaskell/stack/issues/2649
{-
cabalfp <- asks fst
return $
if null missingModules
Expand Down
8 changes: 8 additions & 0 deletions src/Stack/Types/Package.hs
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,14 @@ instance Show GetPackageFiles where
data PackageWarning
= UnlistedModulesWarning (Path Abs File) (Maybe String) [ModuleName]
-- ^ Modules found that are not listed in cabal file

-- TODO: bring this back - see
-- https://github.com/commercialhaskell/stack/issues/2649
{-
| MissingModulesWarning (Path Abs File) (Maybe String) [ModuleName]
-- ^ Modules not found in file system, which are listed in cabal file
-}

instance Show PackageWarning where
show (UnlistedModulesWarning cabalfp component [unlistedModule]) =
concat
Expand All @@ -184,6 +190,7 @@ instance Show PackageWarning where
Just c -> " for '" ++ c ++ "'"
, " component (add to other-modules):\n "
, intercalate "\n " (map display unlistedModules)]
{-
show (MissingModulesWarning cabalfp component [missingModule]) =
concat
[ "module listed in "
Expand All @@ -202,6 +209,7 @@ instance Show PackageWarning where
Just c -> " for '" ++ c ++ "'"
, " component not found in filesystem:\n "
, intercalate "\n " (map display missingModules)]
-}


-- | Package build configuration
Expand Down

0 comments on commit ebfec42

Please sign in to comment.