-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create template-info.yaml #53
Conversation
Shouldn't the descriptions be part of the template itself? This seems like recipe for confusion, having to do the mapping manually. |
It would be nice to have the descriptions as part of the template files themselves, but would that not require downloading and parsing every template file, every time a user runs |
I guess I assumed |
Yeah, cloning the template repo would be sensible for many reasons - commercialhaskell/stack#1595. I don't see much of a problem with having a metadata file like this, though. It might make things clearer if something like template inheritance gets added commercialhaskell/stack#1994 |
@mgsloan You have a much better sense of what's good in this case. I just like to keep things DRY and having to join these two "tables" adds complexity. |
@3noch Yeah, the main issue with adding it to the template itself is that it'd be best to have compatibility with older stack versions. So either way, we'll need to add new files. We can either have a template-info file like this, or add a description file per template. |
@mgsloan For how young stack is, this requirement seems a bit hard to believe (again, you know better than I). I would imagine that |
We can't just silently make Overall our backwards / forwards compatibility is extremely good, and we have no reason to sacrifice this. |
Hmm...perhaps that's the main problem? Without any way to describe changes, you can't safely make any! I.e. perhaps now's a good time to start something like that so that in the future we're not up a creek again? I'm just offering thoughts. You guys are doing an amazing job already. |
Yes, something like that would be good for our various sources of data. PRs appreciated Even with something like that, it seems extreme to flip a switch and disable a feature in all-but-the-newest stack |
- Test ensures `template-info.yaml` exactly matches the contents of the repository - Bump resolver
As discussed here, testing will now fail if there is any discrepancy between templates listed in |
@Narrative Now that is a good idea! |
Oops, forgot to merge this after the stack changes got merged. Thanks again! |
As suggested here and in support of stack pull request #1988.