Improve and expose fetchRepos/fetchReposRaw
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2021
hasufell
commented
Sep 30, 2021
hasufell
force-pushed
the
hasufell/PR/extra-deps-cloning
branch
from
306dfac to
9ecd1ba
Compare
hasufell
changed the title
fetchRepos/fetchReposRawfetchRepos/fetchReposRaw
hasufell
force-pushed
the
hasufell/PR/extra-deps-cloning
branch
from
9ecd1ba to
9bbcdb1
Compare
hasufell
changed the title
fetchRepos/fetchReposRawfetchRepos/fetchReposRaw
|
One thing this doesn't solve is this: if you add a new subdirectory to an exising git extra-dep, it will have to clone once more. I'm not sure if there's a way around that. |
snoyberg
requested changes
Oct 5, 2021
hasufell
force-pushed
the
hasufell/PR/extra-deps-cloning
branch
from
9bbcdb1 to
fc7de76
Compare
snoyberg
reviewed
Oct 5, 2021
src/Pantry/Repo.hs
Outdated
| where | ||
| withCache inner = do | ||
| pkgs <- forM aRepoSubdirs $ \(subdir, rpm) -> withStorage $ do | ||
| loadRepoCache (Repo aRepoUrl aRepoCommit aRepoType subdir) subdir >>= \case |
| -- | Repository without subdirectory information. | ||
| -- | ||
| -- @since 0.5.3 | ||
| data SimpleRepo = SimpleRepo |
src/Pantry/Types.hs
Outdated
| rToSimpleRepo Repo {..} = SimpleRepo { sRepoUrl = repoUrl, sRepoCommit = repoCommit, sRepoType = repoType } | ||
|
|
||
| data AggregateRepo = AggregateRepo | ||
| { aRepoUrl :: !Text |
There was a problem hiding this comment.
Not a strong recommendation, but what about using SimpleRepo here instead of duplicating the fields?
There was a problem hiding this comment.
I'll give it a shot
hasufell
force-pushed
the
hasufell/PR/extra-deps-cloning
branch
from
68e989e to
60ca785
Compare
|
@snoyberg thanks, the next step would be the actual stack PR that calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for commercialhaskell/stack#5411
Please review this carefully. I don't understand most of pantry, but this seemed like the right place to inject and my manual tests succeeded.
Stack will then run
fetchReposRawat a specific place for pre-fetching. So we don't really change existing API.