Localization and nuspec #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional localization (pos, valid values...). Dependencies version changes for nuget.
| <dependency id="System.Reflection.TypeExtensions" version="4.3.0" /> | ||
| <dependency id="System.Resources.ResourceManager" version="4.3.0" /> | ||
| <dependency id="System.Runtime" version="4.3.0" /> | ||
| <dependency id="System.Runtime.Extensions" version="4.3.0" /> | ||
| </group> |
There was a problem hiding this comment.
dependency changes will probably conflict with upcoming netcore standard 2.0 adjustments (#307)
| it => it.AppendFormat("{0} (pos. {1})", specification.MetaName, specification.Index), | ||
| it => it.AppendFormat("value pos. {0}", specification.Index)) | ||
| it => it.AppendFormat("{0} ({1} {2})", specification.MetaName, SentenceBuilder.PositionWord(), specification.Index), | ||
| it => it.AppendFormat("{0} {1}", SentenceBuilder.ValuePositionPhrase(), specification.Index)) |
There was a problem hiding this comment.
I think these localization changes dont actually fit the need.
Some languages might need the number in a different spot. French sometimes likes '1 de juen' instead of 'june 1' for example (thats a date but you should understand my point).
The strings might need to include numeric placeholders too... I feel like localization for now needs to be reconsidered and rearchitected in this lib.
moh-hassan
force-pushed
the
develop
branch
2 times, most recently
from
b211712 to
746885a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in CommandLine.nuspec - dependencies version was changed to 4.3
Additional localization for Default and pos. words, Valid values and value pos phrases.
Also required word as function parameter was removed from some private functions and it was replaced with invoking SentenceBuilder instance functions.
Issue #321
Issue #297