Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add command for existing stdout and stderr properties #89

Merged
merged 5 commits into from
Sep 13, 2019

Conversation

SimonBaeumer
Copy link
Member

@SimonBaeumer SimonBaeumer commented Sep 11, 2019

Fixes #86

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?

@codeclimate
Copy link

codeclimate bot commented Sep 12, 2019

Code Climate has analyzed commit 4e08260 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.1% (0.6% change).

View more on Code Climate.

@SimonBaeumer SimonBaeumer merged commit 4f3cb41 into master Sep 13, 2019
@SimonBaeumer SimonBaeumer deleted the fix-add-command branch October 10, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running commander add --file tests/commander.yaml my-command removes test validation from commander.yaml
1 participant