-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve execution order alphabetically by test title #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not ready for review, but I found sometime. Is the plan to make the alphabetical ordering the default order or flag enabled?
The idea is to enable it by default because currently there is no order guaranteed. |
@dylanhitt review? 👍 |
Sure, I'll look at it Sunday 👍 |
Reviewing Monday, current get to my computer today. Sorry about that. |
No problem, do it when you have time 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The only thing I really have to add is where do we mention "Commander test will execute tests in alphabetical order by default". I was thinking it should go in the commander Hmm maybe a little example showing sequential execution. Something like you mentioned in #128. 001 - it should print hello world:
order: 1
command: echo hello world
stdout: hello world
exit-code: 0
003 - it should validate exit code:
order: 2
command: exit 1
exit-code: 1
002 - another test:
order: 2
command: exit 1
exit-code: 1 Maybe a full suite example in |
Good idea! I will add it to the help and extend the examples. |
08425be
to
ba142f2
Compare
Code Climate has analyzed commit ba142f2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.4% (0.0% change). View more on Code Climate. |
Fixes #
Checklist
Linux
,Windows
andmacOS
?