Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit readme and helper message #132

Closed
wants to merge 2 commits into from
Closed

edit readme and helper message #132

wants to merge 2 commits into from

Conversation

dylanhitt
Copy link
Member

@dylanhitt dylanhitt commented Jun 28, 2020

Closes #129

Adds documentation for the limitations of the --dir feature. These limitation will be addressed #131.

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?

@codeclimate
Copy link

codeclimate bot commented Jun 28, 2020

Code Climate has analyzed commit ada7290 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.8% (0.0% change).

View more on Code Climate.

@SimonBaeumer
Copy link
Member

@see issue #129

@dylanhitt dylanhitt mentioned this pull request Jul 1, 2020
3 tasks
@dylanhitt
Copy link
Member Author

@SimonBaeumer do we want to get this in or wait for #131? Either is fine by me

@SimonBaeumer
Copy link
Member

SimonBaeumer commented Jul 2, 2020

Waiting for #131, the documentation would be misleading if we just skip not *.yaml file types.
If you want you can implement it instead of adding the documentation as we both agreed on it 👍

@dylanhitt
Copy link
Member Author

Alright, I think your idea in #131 is a great one. If you'd like to close or merge it's up to you. I think my focus over the weekend will be #126 as it would implementing #131 a little easier.

Thank you

@SimonBaeumer
Copy link
Member

Then I close this issue and we implement it the approach discussed in #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--dir bug
2 participants