Add stacktraces to EventHandler error logging #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydog187
force-pushed
the
better-stack-traces
branch
from
c3e4060 to
6be112d
Compare
davydog187
commented
Feb 16, 2020
lib/commanded/event/handler.ex
Outdated
| {:error, reason, stacktrace} -> | ||
| Logger.error(fn -> | ||
| describe(state) <> | ||
| " failed to handle event #{inspect(event)} due to: #{inspect(reason)}" |
There was a problem hiding this comment.
In the future, I would suggest we move to the Exception formatter to log these. I can open another issue if we think that's a good idea.
There was a problem hiding this comment.
I added the pretty option to inspect the error messages. It makes the log much easier to read.
davydog187
commented
Feb 16, 2020
davydog187
force-pushed
the
better-stack-traces
branch
from
ffbf643 to
f157bb3
Compare
|
Thanks Dave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#303
Description
This PR logs the stacktrace when a user-written EventHandler raises an error.
Note that I hacked in a test scenario, there might be a better way of doing that. I'm open to suggestions.