Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :ssl to extra_applications #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jdav-dev
Copy link

Ensure :ssl is started before Commanded.Middleware.Auditing.Repo.

@jdav-dev
Copy link
Author

Hi 👋

I opened this PR because commanded_audit_middleware seemed to be starting before ssl and would therefore crash when connecting to the DB. ssl was already present in our own application's extra_applications and wasn't doing the trick. Adding it to commanded_audit_middleware's extra_applications got us working.

Is this the appropriate fix? Is there a better way? I'd like to get this merged unless there's a better way.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant