camerad: abstract cameras

[deanlee]

resolve #25718

[deanlee]

Need to merge #25720 first to Initialize and open camera in AbstractCamera

[deanlee]

All camera-related parameters and functions have been moved to separate files. there is no if CAMERA_ID_AR0231 else in qcom2 anymore

[adeebshihadeh]

Nice, this looks pretty good. Now that VisionIPC has been abstracted out of camerad, we've decided that camerad should just be a highly optimized camera driver for the comma three, so feel free to do any relevant cleanups. I'd also like to better separate the 845-releated code and the image sensor related code (AR0321 and OX03C10).

[deanlee]

ok, i will split it into small PRs and do it incrementally

[deanlee]

Merged #25796

[adeebshihadeh]

@deanlee I'm gonna start bringup of a new sensor soon, so I'm interested in getting camerad cleaned up before that. I'm ready to review & merge these quickly if you wanna rebase this one and help with the cleanup.

[deanlee]

@adeebshihadeh working on this.

[adeebshihadeh]

I started with a clean today #30573. Let's try to do this in small chunks. I'm mostly concerned with pulling out the image sensor stuff right now and splitting it from 845-specific stuff.

[deanlee]

• move AR0231 functions to camera_ar0231.cc camerad: move AR0231 functions to camera_ar0231.cc #30635
• move OX03C10 related code to camera_ox03c10.cc camerad: move sensor related code to /sensors #30647
• refactor sensor parameters to struct camerad: refactor sensor parameters to struct #30639
• encapsulate to classes https://github.com/commaai/openpilot/pull/30650/files

[adeebshihadeh]

Nice, I like breaking things up like this! Want to take over "refactor sensor parameters to struct"?

[adeebshihadeh]

Already looking a lot nicer!

[adeebshihadeh]

@deanlee good to close this? I'm pretty happy with all the sensor abstractions now

[deanlee]

y