-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fingerprints.py with 2024 EU Model RAV4 Hybrid #1512
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
What's your dongle id? |
Hi Shane, my dongle ID is: 918ceea575036e0f |
Noting today's conversation in Discord... |
openpilot is reporting the PRE_COLLISION message's checksum is invalid. Can you put your device on WiFi to upload logs? |
Of course! Just tell me step-by-step how to do it - or point me to the right part of wiki, and i will follow on how to upload logs and where to? ;) I checked the Toyota harness as suggested by Erich, it seems to be the correct one as referenced here: https://github.com/commaai/neo/blob/master/car_harness/v3/Toyota_A_Harness.pdf |
With the latest nightly build and my firmware versions added to fingerprints, the car is not "unrecognized" anymore, but immediately starts to drop PCS/LTA errors when OpenPilot tries to use the sytem :(
Fingerprinting alone does not seem to help working with this EU XA50 RAV4 Hybrid model.