Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fingerprints.py with 2024 EU Model RAV4 Hybrid #1512

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

peanut-hu
Copy link

@peanut-hu peanut-hu commented Nov 20, 2024

With the latest nightly build and my firmware versions added to fingerprints, the car is not "unrecognized" anymore, but immediately starts to drop PCS/LTA errors when OpenPilot tries to use the sytem :(
Fingerprinting alone does not seem to help working with this EU XA50 RAV4 Hybrid model.

@github-actions github-actions bot added car related to opendbc/car/ toyota fingerprint labels Nov 20, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented Nov 20, 2024

What's your dongle id?

@peanut-hu
Copy link
Author

peanut-hu commented Nov 20, 2024

What's your dongle id?

Hi Shane, my dongle ID is: 918ceea575036e0f

@peanut-hu peanut-hu marked this pull request as draft November 21, 2024 00:21
@ErichMoraga
Copy link

Noting today's conversation in Discord...
https://discord.com/channels/469524606043160576/524327905937850394/1309200410568949861

@sshane
Copy link
Contributor

sshane commented Nov 21, 2024

openpilot is reporting the PRE_COLLISION message's checksum is invalid. Can you put your device on WiFi to upload logs?

@peanut-hu
Copy link
Author

peanut-hu commented Nov 21, 2024

openpilot is reporting the PRE_COLLISION message's checksum is invalid. Can you put your device on WiFi to upload logs?

Of course! Just tell me step-by-step how to do it - or point me to the right part of wiki, and i will follow on how to upload logs and where to? ;)
I brought it up with me and put it on power and wifi... if there's nothing else to do, then you should see the device now.
It's 11PM here, i will leave it on overnight. I am going to sleep now.

I checked the Toyota harness as suggested by Erich, it seems to be the correct one as referenced here: https://github.com/commaai/neo/blob/master/car_harness/v3/Toyota_A_Harness.pdf
Another info is that the CANBUS error occurs regardless of whether the OBD cable is plugged in or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ fingerprint toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants