-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize powertrain type classification #1478
Conversation
Ran into a problem where I didn't consider how certain car platforms also have the ability to be available in multiple powertrain types(ex. Ford escape available in ICE, hybrid, and plug-in hybrid ). Converting to draft for now -UPDATE:- |
So this is a lot of complexity for something that isn't be used for openpilot (or to control the car). We need opendbc to continue to get easier to port cars, and this adds something that's just for docs. At the same time, we want good docs. Ideally, anything that's just for docs can be pulled the NHTSA car database: https://www.nhtsa.gov/vin-decoder. Then, we can setup something to dump relevant info from there and store it outside the code. (Also thanks for splitting up the PRs, but you can just merge those other ones back into this one. I suspect it'll take some time to get a framework in place for docs-only info, and it's easier to do it all in one place.) |
Closing this to start a new PR focused on the docs only framework. I will repost my comments above over in PR #1556 |
Wanted to add this so I could query powertrain type easier for opendbc-site
Problem
Currently I could parse the
name
which includes the make, model, and model years to see if hybrid, PHEV, or electric is in it or I could check if the certain car make, has ahybrid/EV
type flagProposed Solution
I am breaking it up into 3 PRs
Current PR:
PowertrainType = PowertrainType.ICE
for backward compatibility2nd PR: Added PowertrainType to individual cars #1484
PowertrainType
for all vehicle definitions invalues.py
3rd PR: Powertrain name formatter for all car makes #1502
values.py
opendbc/car/__init__.py
where if a car is a certainPowertrainType
then add specified string(EV, Hyrbid, PHEV) to end ofname
. This is similar to what/car/ford/values.py
line 83 does, which I think would be beneficial for all car makes to use versus every car make with their own slightly different solution of accomplishing this