fix: monero wallet refresh #1596
Conversation
swap/src/monero/wallet.rs
Outdated
| const GET_HEIGHT_INTERVAL: Duration = Duration::from_secs(5); | ||
| const RETRY_INTERVAL: Duration = Duration::from_secs(2); | ||
|
|
||
| let inner = self.inner.lock().await; |
There was a problem hiding this comment.
@binarybaron doing a bit of debugging on this, it appears this line never returns, at least for given_alice_and_bob_manually_refund_after_funds_locked_both_refund
There was a problem hiding this comment.
Stack trace looks like
swap::monero::wallet::Wallet::refresh::{{closure}} wallet.rs:269
swap::monero::wallet::Wallet::create_from::{{closure}} wallet.rs:148
swap::protocol::alice::state::State3::refund_xmr::{{closure}} state.rs:527
swap::asb::recovery::refund::refund::{{closure}} refund.rs:82
alice_and_bob_refund_using_cancel_and_refund_command::given_alice_and_bob_manually_refund_after_funds_locked_both_refund::{{closure}}::{{closure}}::{{closure}} alice_and_bob_refund_using_cancel_and_refund_command.rs:76
alice_and_bob_refund_using_cancel_and_refund_command::harness::setup_test::{{closure}} mod.rs:140
alice_and_bob_refund_using_cancel_and_refund_command::given_alice_and_bob_manually_refund_after_funds_locked_both_refund::{{closure}} alice_and_bob_refund_using_cancel_and_refund_command.rs:82
Inside refund_xmr, immediately before the create_from call there is a call to watch_for_transfer which itself calls wait_for_confirmations which also locks the client mutex. From the little I know about these locks they should unlock when it goes out of scope, but perhaps there is something going on with the borrowing that keeps it in scope? Not sure.
There was a problem hiding this comment.
Thanks a lot. @delta1 do you know what exact issue could be? I haven't been able to figure it out.
There was a problem hiding this comment.
I don't even understand why the HTTP Clients needs to be a Mutex. That seems so unnecessary and complicates everything...
binarybaron
force-pushed
the
wallet-refresh
branch
2 times, most recently
from
25175a3 to
d58cf96
Compare
Co-Authored-By: binarybaron <[email protected]> Co-Authored-By: Byron Hambly <[email protected]>
binarybaron
force-pushed
the
wallet-refresh
branch
from
d58cf96 to
9f62afe
Compare
|
The tests are passing. Can you give this another review? @delta1 @Einliterflasche |
No it seems the same tests are timing out |
Now they are passing :) |
|
@delta1 I'm going to merge this. Tests are passing and the code is relatively simple. Please ping me if you want to revert something. |
This PR changes the following behaviour in the refresh functionality of the monero wallet
no connection to daemoneven though the daemon is available. I'm not 100% sure why this happens but retrying often fixes the issuemonero-wallet-rpcis started with the--no-initial-syncflag which ensures that as soon as it's started, it's ready to respond to requestsmonero-wallet-rpcwas upgraded tov0.18.3.1because this PR Wallet refresh improvements monero-project/monero#8941 has improved some of the issues mentioned aboveThis PR is part of a larger effort to fix this issue #1432