This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
Remove possibility for in-memory DB #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make much sense to have it because of the way our DB code is setup. In-memory DBs of SQLite only live as-long as the connection is open. This means, we drop the DB just after we ran the migrations. In order to properly support in-memory DBs, we'd have to rework the way our DB code handles the connections as we would need to keep them around. In-memory DBs would only be useful for testing and we don't need them for now, hence it is not worth supporting them properly and certainly not in-properly.
|
Are you sure the changelog does not need updating? |
D4nte
approved these changes
Nov 18, 2019
tcharding
approved these changes
Nov 18, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 18, 2019
1662: Remove possibility for in-memory DB r=mergify[bot] a=thomaseizinger It doesn't make much sense to have it because of the way our DB code is setup. In-memory DBs of SQLite only live as-long as the connection is open. This means, we drop the DB just after we ran the migrations. In order to properly support in-memory DBs, we'd have to rework the way our DB code handles the connections as we would need to keep them around. In-memory DBs would only be useful for testing and we don't need them for now, hence it is not worth supporting them properly and certainly not improperly. Co-authored-by: Thomas Eizinger <[email protected]>
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Dec 16, 2019
1772: Bump serde from 1.0.103 to 1.0.104 r=mergify[bot] a=dependabot-preview[bot] Bumps [serde](https://github.com/serde-rs/serde) from 1.0.103 to 1.0.104. <details> <summary>Release notes</summary> *Sourced from [serde's releases](https://github.com/serde-rs/serde/releases).* > ## v1.0.104 > - Revert stabilization of Serialize/Deserialize impls for `!` to account for [rust-lang/rust#67224](https://github-redirect.dependabot.com/rust-lang/rust/pull/67224) </details> <details> <summary>Commits</summary> - [`234fbfd`](serde-rs/serde@234fbfd) Release 1.0.104 - [`b9909ce`](serde-rs/serde@b9909ce) Revert "Remove never_type feature gate" - [`d540e72`](serde-rs/serde@d540e72) Format with rustfmt 2019-10-07 - [`13d0899`](serde-rs/serde@13d0899) Add missing import in de_enum expand test - [`4fefa7a`](serde-rs/serde@4fefa7a) Format imports in expandtest inputs - [`9048660`](serde-rs/serde@9048660) Update test suite to nightly-2019-11-26 - [`0b303c7`](serde-rs/serde@0b303c7) Mark tests ignored on emscripten rather than omitting - [`c371563`](serde-rs/serde@c371563) Reduce nesting of macrotest test cases - [`d17d8eb`](serde-rs/serde@d17d8eb) Rely on std::process::Command's path search - [`bcaebdb`](serde-rs/serde@bcaebdb) Merge pull request [#1662](https://github-redirect.dependabot.com/serde-rs/serde/issues/1662) from eupn/use-macrotest - Additional commits viewable in [compare view](serde-rs/serde@v1.0.103...v1.0.104) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=serde&package-manager=cargo&previous-version=1.0.103&new-version=1.0.104) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in the `.dependabot/config.yml` file in this repo: - Update frequency - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make much sense to have it because of the way our DB code is setup.
In-memory DBs of SQLite only live as-long as the connection is open. This means, we drop the DB just after we ran the migrations. In order to properly support in-memory DBs, we'd have to rework the way our DB code handles the connections as we would need to keep them around. In-memory DBs would only be useful for testing and we don't need them for now, hence it is not worth supporting them properly and certainly not improperly.