This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
GP-685 - error handling and username fixes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoelLH
commented
Aug 23, 2017
NoelLH
commented
- Fix handling of Error XML responses, correctly pulling through Worldpay's error message & code instead of 'PENDING'.
- Add support for 'username' property, which is optional and distinct from merchant code.
- Test some more realistic error cases, including the non-XML response when a request is unauthenticated.
…gh Worldpay's error message & code instead of 'PENDING'. Add support for 'username' property, which is optional and distinct from merchant code. Test some more realistic error cases, including the non-XML response when a request is unauthenticated.
ayanozturk
approved these changes
Aug 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.