Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Commit

Permalink
Merge pull request #13 from comicrelief/doc-updates
Browse files Browse the repository at this point in the history
Doc updates
  • Loading branch information
zhibek authored Sep 21, 2017
2 parents b01c9ae + 0bf6e3f commit 347c005
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Omnipay: Worldpay Hosted Corporate Gateway (XML)

_Caution!_ This fork from teaandcode/omnipay-worldpay-xml is in active development, and not yet widely tested.

**WorldPay Hosted driver for the Omnipay PHP payment processing library**

[Omnipay](https://github.com/omnipay/omnipay) is a framework agnostic,
Expand Down Expand Up @@ -42,11 +40,15 @@ To set another one, use `PurchaseRequest::setDescription()`.

## Notification setup

This library aims to be able to give sensible answers for `isValid()`, `isAuthorised()`, `isPending()` and `isCancelled()`, if you select every possible type on this screen:
This library aims to be able to give sensible answers for `isValid()`, `isAuthorised()`, `isPending()` and `isCancelled()`, if you select almost every possible type on this screen:

![Notification setup](./docs/Notification%20setup.png "Notification setup")

It's probably safest to tick everything you can, so as not to miss notifications you might care about.
Generally it's good to tick everything you can, so as not to miss notifications you might care about.

However we've had to **not tick _SENT_FOR_AUTHORISATION_** because of an apparent Worldpay bug that sends two _AUTHORISED_ notifications when this is selected, instead of sending the additional type.

We have not yet had confirmation from Worldpay on whether this is expected to affect the production gateway or if it will be fixed, so it's safer not to enable this notification for now.

## Notification verification

Expand Down
Binary file modified docs/Notification setup.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/Omnipay/WorldpayCGHosted/Message/Notification.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ public function __construct($data, $notificationOriginIp)
* Get the most recent Worldpay status string as of this notification,
* e.g. AUTHORISED, CAPTURED, REFUSED, CANCELLED, ...
*
* @link http://bit.ly/wp-notification-statuses Which statuses trigger notifications
* @link http://bit.ly/wp-status-detail More detail on statuses
* @link https://bit.ly/wp-cg-notification-statuses Which statuses trigger notifications
* @link https://bit.ly/wp-cg-payment-process More detail on the payment process with statuses
*
* @return string|null
*/
Expand Down
2 changes: 1 addition & 1 deletion src/Omnipay/WorldpayCGHosted/Message/RedirectResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function getRedirectUrl()
{
$url = $this->getOrder()->reference->__toString();

// Custom result URLs available: http://bit.ly/2uRpuX0
// Custom result URLs available: https://bit.ly/2uRpuX0
if (!empty($this->successUrl)) {
$url .= '&successURL=' . rawurlencode($this->successUrl);
$url .= '&pendingURL=' . rawurlencode($this->successUrl);
Expand Down

0 comments on commit 347c005

Please sign in to comment.