Fix small issues on Joblist #3767
Conversation
|
Why is it separate? Can't the user click on "Failed" and the error message be displayed? |
Trying to apply a somewhat consistent design: if it has an icon it is a clickable button. At the same time I aimed to keep the status badge consistent, while previewing the error message. Imho the current design is better: having the error in the results tab where there are all kinds of buttons already. |
|
The use wants to know why something failed. It makes more sense to keep that information together rather than putting it in the output, which is unrelated. |
Shall I push the Failed badge and error together to create a single badge? |
|
Yes - what we had before was clicking on "Failed" and then getting a modal with the error message. It worked well. |
|
Same for "Succeeded with warnings". |
|
Picking this up now. |
|
New interaction: Screen.Recording.2025-01-10.at.13.29.53.mov |
| </button> | ||
| </div> | ||
| <div class="text-left modal-body"> | ||
| {{ object.stderr }} |
There was a problem hiding this comment.
This will dump the entirety of stderr, I think this needs to be passed through user_error like in the components application. Or maybe that work should be done when the job completes so that object.error_message is populated and these two conditional blocks can be unified?
| <i class="fa fa-info-circle mr-1"></i>View Result Details | ||
| </a> | ||
| </div> | ||
| {% if object.rendered_result_text %} |
There was a problem hiding this comment.
Should we show a link to the result even if the rendered_result_text is empty? For algorithms that do not implement the legacy "results-json-file" this is just an empty string so the results column is empty:
Closes #3436
Screen.Recording.2024-12-24.at.16.28.39.mov