Budget alerts

[koopmant]

related to https://github.com/DIAGNijmegen/rse-grand-challenge-admin/issues/319

[jmsmkn]

I find this if statement hard to grok. Can you maybe assign some variables to help with readability? Style wise, it is usually easiest for other developers to have everything laid out for them, and the if statement be quite straightforward:

if should_do_something:
    do_something()

then should_do_something is built up through logic:

it_is_sunday = datetime.datetime.now().weekday() == 6
feeling_under_the_weather = random.random() < 0.05

should_do_something = not it_is_sunday and not feeling_under_the_weather

[pkcakeout]

Just to confirm: I also find that hard to read. Black did not do this statement justice. All the operators "seem to be equal" even though this is an example of the rare ternary comparison... hard to parse!

[koopmant]

Yeah, sorry about this one. I was optimizing the code and it got a bit out of hand. And then, as Paul said, Black came in and made matters even worse... I'll clean it up!

[koopmant]

It should be a lot better now.

[amickan]

LGTM. Just some small comments.

I do have one general question: we're only taking into account compute costs here, not storage costs. I see that this is also what is checked in percent_budget_consumed and is what is displayed on the cost overview. Yet, with every new submission, we presumably also store a new Docker image, which affects the storage costs. Are the Docker storage costs usually overestimated on the invoice and hence hard to exceed?

[amickan]

Oh I see that James and I looked at this in parallel. Go with James' comments, obviously. ;-)

[jmsmkn]

Oh I see that James and I looked at this in parallel. Go with James' comments, obviously. ;-)

Yes it seems like the review tab does not auto update like the comments one. Luckily (or rather unsurprisingly) we gave the same direction!

[jmsmkn]

I do have one general question: we're only taking into account compute costs here, not storage costs. I see that this is also what is checked in percent_budget_consumed and is what is displayed on the cost overview. Yet, with every new submission, we presumably also store a new Docker image, which affects the storage costs. Are the Docker storage costs usually overestimated on the invoice and hence hard to exceed?

We should take into account storage but do not. We have the old problem that the two fields are separate (like how we used to assign budget/submissions per phase). I don't think there is a reason to consider them separately now. There is the problem that the storage costs are an ongoing rate, whereas the compute costs are fixed in time. We don't have per-month tracking of storage costs, I think to really make it work we would need that.