-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Component Interface Value representations #3364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsmkn
reviewed
Jun 5, 2024
...andchallenge/core/templates/grandchallenge/partials/component_interface_values/fallback.html
Outdated
Show resolved
Hide resolved
jmsmkn
reviewed
Jun 5, 2024
...lenge/core/templates/grandchallenge/partials/component_interface_values/inline/fallback.html
Outdated
Show resolved
Hide resolved
jmsmkn
reviewed
Jun 5, 2024
...challenge/core/templates/grandchallenge/partials/component_interface_values/inline/file.html
Outdated
Show resolved
Hide resolved
jmsmkn
reviewed
Jun 5, 2024
jmsmkn
reviewed
Jun 5, 2024
jmsmkn
reviewed
Jun 5, 2024
jmsmkn
reviewed
Jun 7, 2024
jmsmkn
reviewed
Jun 7, 2024
jmsmkn
reviewed
Jun 7, 2024
app/grandchallenge/components/templates/components/partials/civ_inline.html
Outdated
Show resolved
Hide resolved
jmsmkn
reviewed
Jun 7, 2024
app/grandchallenge/components/templates/components/partials/civ_inline/file_thumbnail.html
Outdated
Show resolved
Hide resolved
…v_inline/file_thumbnail.html Co-authored-by: James Meakin <[email protected]>
jmsmkn
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have several slightly different not-so-nice, representations of component interface values (CIVs).
This PR contains a rework of these representations in the job detail pages for evaluation and algorithms. The ultimate goal is to extend its usage to the ArchiveItem detail page and ArchiveItem/DisplaySet list pages.
Current 'inline' view
New 'inline' view
Template tags
Two template tags are introduced:civ
andciv_inline
. Each tag takes a component interface value as the only argument and renders an HTML representation of the CIV. The inline variant is meant for list-like representations where horizontal space is limited and relies on a modal—the regular one where there is plenty of horizontal space to render the CIV proper.A new template civ.html is introduced that accepts the arguments
civ
anddisplay_inline
. Thedisplay_inline
is a switch that can be set to True and is meant for list-like representations where horizontal space is limited and relies on a modal—the regular one where there is plenty of horizontal space to render the CIV properVega Lazy loading
In addition, this PR adds lazy loading for vega charts which is very much needed if viewing a list of CIVSets that output charts.
New Fixtures
CIVs are a crucial part of development now, and I think adding a bunch of test CIVs by hand is a lot of hassle. This, I think, plays a part in these representations flying under the radar. As such, this PR also introduces the
scripts/component_interface_value_fixtures.py
. This repeatable script creates an algorithm job that has an overabundance of different CIVs for quick development.The screenshots are made based on this fixture.