-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Direct Messages #3093
Merged
Merged
Add Direct Messages #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amickan
reviewed
Nov 20, 2023
jmsmkn
commented
Nov 20, 2023
jmsmkn
commented
Nov 20, 2023
jmsmkn
commented
Nov 20, 2023
jmsmkn
commented
Nov 20, 2023
amickan
reviewed
Nov 20, 2023
app/grandchallenge/core/templates/grandchallenge/partials/userlinks.html
Show resolved
Hide resolved
amickan
reviewed
Nov 20, 2023
app/grandchallenge/direct_messages/templates/direct_messages/conversation_detail.html
Show resolved
Hide resolved
amickan
reviewed
Nov 20, 2023
amickan
reviewed
Nov 20, 2023
amickan
previously approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive! I worked my way through the code and tried to break it, but it all appears to be working as intended :-) I think some more tests would be good though.
I really like the look and feel of the UI for the messages as well.
HarmvZ
added a commit
to DIAGNijmegen/rse-gcapi
that referenced
this pull request
Jul 26, 2024
Faker was added on gc in comic/grand-challenge.org#3093, but it was not added to poetry and it is not available in the production container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Direct Messages application. It introduces three main new models:
Conversation
: Many users areparticipants
of one conversation. Many permissions are added to each conversation - view, create_conversation_direct_message, mark_conversation_read, mark_conversation_message_as_spam.DirectMessage
: Has a foreign key to aconversation
,sender
and which users have not read this message. The sender can delete the message and the conversation participants can mark the message as spam. If a direct message is created the other participants in the group have the message marked as unread. If a message is deleted or marked as spam then all of the unread markers are deleted.Mute
: tracks which users have muted which other users. If a direct message is created and the receiver has muted the sender the message is not marked as unread by the receiver.The views use HTMX. As a conversation is loaded all of the messages are marked as read as a callback. For now only challenge admins can message their participants.
See https://github.com/DIAGNijmegen/rse-roadmap/issues/255