Annotation CIV disapears after uploading image CIV #3104
Assignees
Labels
Comments
amickan
added a commit
that referenced
this issue
Dec 4, 2023
When uploading a new image to an existing archive item, all non-image CIVs of that same item used to get deleted. The reason for this was that we checked for existing CIVs with the same image and deleted those. In the case of new image uploads, however, civ.image is still empty at the time of checking, and so it matched all CIVs with image=None. I was confused why we need this check at all. After some digging, I realized that it's necessary to enable updating of the interface of an image through the api (say from generic medical image to something more specific). This was a common use case when it was added. I'm in doubt whether we still need or want to offer this feature. It means that you can never have an archive item with the same image attached to different interfaces. Seems like a reasonable restriction to me, but it's a restriction that we don't enforce anywhere else (i.e. for display sets or jobs) as far as I know. Finally, adding a new interface to an archive item through the dropdown menu no longer worked since it used inline js. Fixed that as well. Closes #3104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When uploading a Generic Overlay CIV to an archive item that contains one or multiple annotations CIVs (tested with 2D bounding box and point annotations), those annotations disappear.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The annotation CIVs should remain.
Screenshots
Recording.2023-11-27.161340.mp4
The text was updated successfully, but these errors were encountered: