-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The nodes I suggested #202
Conversation
Everything here seems to be working so far for me. I haven't tested the custom nodes yet since I'm testing some of my own currently. Not sure what that patch.diff file was about but removing it didn't affect me seemingly, so I left it out. Also, I left out the Delete portion. It felt too prominent and dangerous for my taste. That should possibly be stuck separately or perhaps toggled from the little gear menu for those that don't want or need it. If it were stuck in the little gear menu with a toggle, possibly it could show the default directory and allow changing/setting it. This could be handy, knowing it's set to delete a Test directory is fine I think. More so if it said which as it offered. I may just be rambling now though :) Anyways, thanks. The optional inputs are nice. I'm sure the new nodes are too :) |
After doing a lot of testing on my own, using the method I was using results in the following problems;
All in all, it doesn't seem to be a great method, I'll see what else I can find or figure out |
Merge Main into Local
@comfyanonymous Please have a look and take some of the items I've added
Items just for me:
|
Yes, can you make separate pull requests for these so I can review them separately since they are not tied together. I'm not interested by a "delete all" button but a route to delete specific files in the output folder could be useful. Optional inputs are good. What does your Saved Images List Node do? Your custom ksampler is no longer needed since this got merged: #243 |
Will do when I next get a gap. |
Merge Latest code from ComfyAnon to Silversith
Please have a look and see what you think, I'm no expert at this, but I tried.
Had to do one fix for the "optional inputs" on the app.js and added a custom.json save + preview image.