Add track query extraction in onPostBootstrap #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for figuring out the missing steps before rewriting the plugin. 😄
Yeah, we have an opened issue for that: #103 |
|
@all-contributors please add @edykim for bug, code |
|
I've put up a pull request to add @edykim! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had time to check the inconsistency between
gatsby developandgatsby build. At the initial ofgatsby develop, the types from static queries do not generate if there is a cache. These components are loaded inonPostBootstrapthroughQUERY_EXTRACTION_BABEL_SUCCESSaction. Therefore, that action needs to be handled inonPostBootstrapas well.The steps are somewhat different than
onPostBootstrapone, so I just put a similar logic. If this logic solves the problem, we can make it nicer.Some of the generated files are still different e.g.
PagesQuery,port,host. These are dev only option, and it appears in generating process. I guess it should be an option to filter out. Note: PagesQuery is from the dev-404 page.