Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix RPC/OpenAPI references/links #416

Merged
merged 2 commits into from
Feb 28, 2023
Merged

docs: Fix RPC/OpenAPI references/links #416

merged 2 commits into from
Feb 28, 2023

Conversation

thanethomson
Copy link
Contributor

Ports changes from #410 to main.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@thanethomson thanethomson added documentation Improvements or additions to documentation backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x labels Feb 28, 2023
@thanethomson thanethomson requested a review from a team as a code owner February 28, 2023 15:40
andynog
andynog approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@thanethomson thanethomson merged commit 9ad2db8 into main Feb 28, 2023
@thanethomson thanethomson deleted the thane/port-410 branch February 28, 2023 15:48
mergify bot pushed a commit that referenced this pull request Feb 28, 2023
@thanethomson @mergify
docs: Fix RPC/OpenAPI references/links (#416)
4616601 
(cherry picked from commit 9ad2db8)

# Conflicts:
#	docs/core/rpc.md
#	rpc/openapi/README.md
@mergify mergify bot mentioned this pull request Feb 28, 2023
Merged
thanethomson added a commit that referenced this pull request Feb 28, 2023
@mergify @thanethomson
docs: Fix RPC/OpenAPI references/links (backport #416) (#417)
d136c53 
* docs: Fix RPC/OpenAPI references/links (#416)

(cherry picked from commit 9ad2db8)

# Conflicts:
#	docs/core/rpc.md
#	rpc/openapi/README.md

* Resolve conflicts

Signed-off-by: Thane Thomson <[email protected]>

---------

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andynog andynog andynog approved these changes

Assignees
No one assigned
Labels
backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x documentation Improvements or additions to documentation
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thanethomson @andynog