Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimally renaming v0.34.x #128

Closed
5 tasks done
Tracked by #93
thanethomson opened this issue Jan 16, 2023 · 1 comment
Closed
5 tasks done
Tracked by #93

Minimally renaming v0.34.x #128

thanethomson opened this issue Jan 16, 2023 · 1 comment
Labels
rename Renaming our fork
Milestone
2023-Q1

Comments

@thanethomson
Copy link
Contributor

thanethomson commented Jan 16, 2023 •
edited by lasarojc
Loading

We need to rename our CometBFT release that will be compatible with the v0.34.x series, but as per @sergio-mena's concerns raised in today's team meeting, we want to:

  1. Minimize the friction for users in switching from Tendermint Core to CometBFT (I say "minimize" because there's no way to totally eliminate any friction - at the very least users have to switch their dependencies)
  2. Ensure total compatibility between CometBFT v0.34.25 and Tendermint Core v0.34.24.

With these goals in mind, we need to:
@thanethomson thanethomson mentioned this issue Jan 16, 2023
Closed
44 tasks
@thanethomson thanethomson added the rename Renaming our fork label Jan 17, 2023
@lasarojc
Copy link
Contributor

lasarojc commented Jan 25, 2023 •
edited by thanethomson
Loading

cometbft/qa-infra#1 addresses the renaming in QA Infra, but it leaves behind a TMHOME to be renamed later.

@thanethomson thanethomson added this to the 2023-Q1 milestone Feb 25, 2023
cometcrafter pushed a commit to graphprotocol/cometbft that referenced this issue Aug 2, 2024
@ValarDragon @cason
feat(p2p): render HasChannel(chID) is a public p2p.Peer method (#… (
be6b582 
cometbft#128)

* feat(p2p): render `HasChannel(chID)` is a public `p2p.Peer` method (cometbft#3510)

Closes: cometbft#3472

It also prevents reactors from starting routines intended to send
messages to a peer that does not implement/support a given channel.
Because all `Send()` or `TrySend()` calls from this routine will be
useless, always returning `false` and possibly producing some busy-wait
behavior (see cometbft#3414).

The changes are restricted to: mempool and evidence reactor, because
they use a single channel and have a sending routine peer peer, and two
of the consensus routines, for Data and Votes.

Block and State sync reactors have smarter ways to deal with
unresponsive peers, so probably this check is not needed.

---

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

* One more test fix

* Add changelog

* Update changelog

---------

Co-authored-by: Daniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rename Renaming our fork
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q1
Development

No branches or pull requests
2 participants
@thanethomson @lasarojc