Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate BoltDB and ClevelDB as backend DBs #177

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

alesforz
Copy link
Contributor

@alesforz alesforz commented Aug 9, 2024

Context

We have decided to reinstate BoltDB and CLevelDB. These will remain marked as deprecated until a future version of CometBFT, where we plan to discontinue cometBFT-db and standardize on a single backend database.

Changes

This PR:

This reverts commit badc0b8.

We decided to reinstate boltDB and clevelDB and mark them as deprecated until a
future version of CometBFT in which we'll drop cometbft-db and support only 1 backend
DB.
@alesforz alesforz added the chore label Aug 9, 2024
@alesforz alesforz self-assigned this Aug 9, 2024
@alesforz alesforz added the dependencies Pull requests that update a dependency file label Aug 9, 2024
@alesforz alesforz marked this pull request as ready for review August 9, 2024 08:29
@alesforz alesforz requested a review from a team as a code owner August 9, 2024 08:29
Copy link
Contributor

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and reverted commits match.

The exception are some comments, probably added by another PR.

Also, I am not sure regarding the changelog. As it appears to me that we are dropping v0.13.0. In this way, just to remove the changelog should be enough. The reversion can be informed in the changelog for the new release.

db.go Outdated Show resolved Hide resolved
db.go Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this changelog? Isn't easier to remove the previous one?

Co-authored-by: Daniel <[email protected]>
@alesforz
Copy link
Contributor Author

alesforz commented Aug 9, 2024

This and reverted commits match.

The exception are some comments, probably added by another PR.

Also, I am not sure regarding the changelog. As it appears to me that we are dropping v0.13.0. In this way, just to remove the changelog should be enough. The reversion can be informed in the changelog for the new release.

Are you suggesting to delete the entire v0.13.0 changelog and its summary in the CHANGELOG.md file?

@alesforz alesforz requested review from melekes and cason August 9, 2024 12:27
Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, had a minor comment on a change

db.go Show resolved Hide resolved
db.go Outdated Show resolved Hide resolved
@alesforz alesforz added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 9db1a44 Aug 9, 2024
6 checks passed
@alesforz alesforz deleted the alesforz/reinstate-boltdb-cleveldb branch August 9, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants