-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate BoltDB and ClevelDB as backend DBs #177
Conversation
This reverts commit badc0b8. We decided to reinstate boltDB and clevelDB and mark them as deprecated until a future version of CometBFT in which we'll drop cometbft-db and support only 1 backend DB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and reverted commits match.
The exception are some comments, probably added by another PR.
Also, I am not sure regarding the changelog. As it appears to me that we are dropping v0.13.0. In this way, just to remove the changelog should be enough. The reversion can be informed in the changelog for the new release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this changelog? Isn't easier to remove the previous one?
Co-authored-by: Daniel <[email protected]>
Are you suggesting to delete the entire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, had a minor comment on a change
Context
We have decided to reinstate BoltDB and CLevelDB. These will remain marked as deprecated until a future version of CometBFT, where we plan to discontinue cometBFT-db and standardize on a single backend database.
Changes
This PR:
Iterator
APIs to comply with feat!: IteratorKey()
andValue()
no longer return a copy #168