Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPIK-418] Add endpoint to return all feedback score names #646

Merged
merged 3 commits into from
Nov 18, 2024
Merged

[OPIK-418] Add endpoint to return all feedback score names #646

merged 3 commits into from
Nov 18, 2024

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Nov 15, 2024 •
edited
Loading

Details

  • Add endpoint to retrieve all feedback score names
  • Fix parallel container starting

Issues

OPIK-418

Testing

  • Filter by project_id
  • Filter by with_experiments_only
  • Both filters
  • No filters

@thiagohora thiagohora requested a review from a team as a code owner November 15, 2024 14:04
@thiagohora thiagohora self-assigned this Nov 15, 2024
idoberko2
idoberko2 reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@idoberko2 idoberko2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I really liked the test clients.
Had a few comments.

@thiagohora thiagohora merged commit 767a0f1 into main Nov 18, 2024
7 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-418_add_endpoint_to_return_all_feedback_score_names branch November 18, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoberko2 idoberko2 idoberko2 approved these changes

Assignees

@thiagohora thiagohora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagohora @idoberko2