Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-402]: handle project name and score definitions for evaluate(); #613

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

aadereiko
Copy link
Contributor

@aadereiko aadereiko commented Nov 12, 2024

Details

  • Now, the scores during evaluate work properly. They handle the project_name correctly
  • I wanted to write some tests but for the time being, there is no way to get the project info by a name. So, it's best to do it after the BE is ready

Issues

Resolves #553

Testing

Documentation

@aadereiko aadereiko requested a review from a team as a code owner November 12, 2024 15:06
client: opik_client.Opik, test_results: List[test_result.TestResult]
client: opik_client.Opik,
test_results: List[test_result.TestResult],
project_name: Optional[str] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be just project_name: Optional[str] without the default value.
There is no real need for the default value because we call this function in one place only and pass project_name explicitly.
Such arguments with the default value in the middle of the processing pipeline often lead to unnoticed bugs.

@alexkuzmik alexkuzmik merged commit 72b027a into main Nov 14, 2024
21 checks passed
@alexkuzmik alexkuzmik deleted the sashaa/OPIK-402/evaluate-project-name-handle branch November 14, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot filter traces on Feedback scores when the source is "SDK"
2 participants