[OPIK-390]: [SDK] add a project name to creation of traces; #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadereiko
changed the title
aadereiko
changed the title
alexkuzmik
requested changes
Nov 12, 2024
sdks/python/src/opik/url_helpers.py
Outdated
| @@ -6,6 +6,7 @@ | |||
| URL_ACCOUNT_DETAILS_POSTFIX: Final[str] = "api/rest/v2/account-details" | |||
| URL_WORKSPACE_GET_LIST_POSTFIX: Final[str] = "api/rest/v2/workspaces" | |||
| HEALTH_CHECK_URL_POSTFIX: Final[str] = "/is-alive/ping" | |||
| SAFE_PARSE_URL: Final[str] = ":/&?=" | |||
There was a problem hiding this comment.
Let's rename it to ALLOWED_URL_CHARACTERS to be more descriptive
sdks/python/src/opik/url_helpers.py
Outdated
| ui_url = get_ui_url() | ||
|
|
||
| return urllib.parse.quote( | ||
| f"{ui_url}/{workspace}/redirect/projects?name={project_name}", |
There was a problem hiding this comment.
Let's split it in 2 steps:
project_path = urllib.parse.quote(f"{workspace}/redirect/projects?name={project_name}", safe=...)
return urllib.parse.join(ui_url, project_path)It's safer to use join instead of strings formatting for concatenating url parts, because there are cases when someone adds/doesn't add / in the end or in the beginning of the url part. And it might lead to stuff like https://www.opik.com//my_workspace, join function is quite smart about such stuff.
alexkuzmik
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Resolves #
Testing
Documentation